fix(stackable-versioned): Validate kind, desired and current version #1061
+1,295
−224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernauer
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…/k8s.rs Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
sbernauer
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Techassi
requested changes
Jun 24, 2025
crates/stackable-versioned-macros/src/codegen/container/struct/k8s.rs
Outdated
Show resolved
Hide resolved
crates/stackable-versioned-macros/src/codegen/container/struct/k8s.rs
Outdated
Show resolved
Hide resolved
crates/stackable-versioned-macros/src/codegen/container/struct/k8s.rs
Outdated
Show resolved
Hide resolved
crates/stackable-versioned-macros/src/codegen/container/struct/k8s.rs
Outdated
Show resolved
Hide resolved
crates/stackable-versioned-macros/src/codegen/container/struct/k8s.rs
Outdated
Show resolved
Hide resolved
crates/stackable-versioned-macros/src/codegen/container/struct/k8s.rs
Outdated
Show resolved
Hide resolved
…/k8s.rs Co-authored-by: Techassi <git@techassi.dev>
…/k8s.rs Co-authored-by: Techassi <git@techassi.dev>
Co-authored-by: Techassi <git@techassi.dev>
Co-authored-by: Techassi <git@techassi.dev>
82 tasks
Techassi
changed the title
sbernauer
changed the title
Techassi
approved these changes
Jun 25, 2025
sbernauer
moved this from Development: In Review
to Development: Done
in Stackable Engineering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#1056 will also fix at least some of the bugs, but I would prefer to fix the bugs fast and have tests.
I'm happy that my code gets overwritten by #1056 as longs as the tests pass.
By fixing the problems we can continue on working an the actual conversion HTTPS webhook stuff.
Description
Fix some problems in the (brand new) conversions. And most important: Re-add tests that temporarily have been removed from #1050
test.stackable.tech/v1alpha1as apiVersion, notv1alpha1PS: The diff is so big because lots of tests (snapshots) changed. Actual code change is only a small portion.